Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help the developer in case they forgot to enable @Push #43

Closed
Legioth opened this issue Jun 2, 2021 · 0 comments
Closed

Help the developer in case they forgot to enable @Push #43

Legioth opened this issue Jun 2, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Legioth
Copy link
Member

Legioth commented Jun 2, 2021

If you try to use Collaboration Engine without enabling @Push in Flow, then things will typically be broken in ways that are not obvious. This is a quite common mistake to do when trying out something simple and it can be quite difficult to debug.

There is already logic in ComponentConnectionContext::checkForPush that checks for this and logs a warning (in development mode), but this warning is easily ignored. In addition to logging a warning, the same logic could also enable push if it isn't enabled.

We should then also provide a way of configuring CE to not enable push in case the developer for some reason wants to e.g. use UI::setPollInterval instead. API for this could be in CollaborationEngineConfiguration, e.g. as configuration.setAutomaticallyActivatePush(false).

@Legioth Legioth added the enhancement New feature or request label Jun 2, 2021
@Legioth Legioth closed this as completed Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant