Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperTextField.inputMode cannot be set inside a Grid.Column #513

Closed
haenni opened this issue May 28, 2024 · 6 comments · Fixed by #515
Closed

SuperTextField.inputMode cannot be set inside a Grid.Column #513

haenni opened this issue May 28, 2024 · 6 comments · Fixed by #515
Assignees
Labels
bug Something isn't working

Comments

@haenni
Copy link

haenni commented May 28, 2024

Entering edit-mode of a grid with SuperBigDecimalField set as editorComponent triggers an error in the browser console:

TypeError: Cannot set properties of undefined (setting 'inputMode')

Steps to reproduce:

  1. extract reproducer view from attached zip file
  2. access the view from some vaadin project, eg. one of the vaadin-starter projects
  3. on the view, double click either one cells of the second column to enter edit mode.
  4. observe error in browser console.

superfields 0.19.0
Vaadin 24.3.5
reproducer_view.zip

@vaadin-miki
Copy link
Owner

hello @haenni - thank you for using my components!

while I have to apologise for the bug, I would like to thank you for your absolutely perfect bug report 🌞
from what I can see, Grid being Grid initialises components differently from any other container (see #243) - I think though I should be able to fix it

@vaadin-miki vaadin-miki self-assigned this May 31, 2024
@vaadin-miki vaadin-miki added the bug Something isn't working label May 31, 2024
@vaadin-miki vaadin-miki added this to the Next release milestone May 31, 2024
vaadin-miki added a commit that referenced this issue May 31, 2024
@vaadin-miki vaadin-miki changed the title Error in browser console when SuperBigDecimalField is used as editorComponent inside a Grid.Column SuperTextField.inputMode cannot be set inside a Grid.Column May 31, 2024
vaadin-miki added a commit that referenced this issue May 31, 2024
@vaadin-miki
Copy link
Owner

this issue is now fixed in development and will be released as 0.19.1 some time next week

@haenni
Copy link
Author

haenni commented Jun 18, 2024

@vaadin-miki
You are welcome :) Thank you for your quick response and the fix.
Is there already a planned release date for version 0.19.1?

vaadin-miki added a commit that referenced this issue Jul 15, 2024
* #508 likely done (#509)
* #54 Swedish translation to superdatepickeri18n.properties (#507) (#510)
* #511 done (#512)
* #513 #514 done (#515)
* (bot) release notes updated for 0.19.1
* (bot) version updated to 0.19.1

---------
Co-authored-by: Sebastian Penttinen <31658152+sebastianpenttinen@users.noreply.github.com>
Co-authored-by: sebastianPenttinen <sebastian.penttinen@beanbakers.fi>
@vaadin-miki
Copy link
Owner

@haenni please accept my apologies for the delay in releasing 0.19.1 - I simply forgot to do it before my holiday 🌞 anyway, 0.19.1 is now released, and the version for Vaadin 14 will be released by the end of the month

@haenni
Copy link
Author

haenni commented Jul 16, 2024

@vaadin-miki
No worries, thanks for the release. Will it be made available as maven artifact?

@vaadin-miki
Copy link
Owner

@haenni it should already be available (https://central.sonatype.com/artifact/pl.unforgiven/superfields) - it happened with a delay, because they changed the authentication method to central, so I had to fix that first :) but now everything seems to be ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants