Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AFTER_* label positions are incorrect for custom fields #511

Closed
vaadin-miki opened this issue Dec 22, 2023 · 0 comments · Fixed by #512
Closed

AFTER_* label positions are incorrect for custom fields #511

vaadin-miki opened this issue Dec 22, 2023 · 0 comments · Fixed by #512
Assignees
@vaadin-miki
Labels
bug Something isn't working
Milestone
0.19.1 - Bug fixes

Comments

@vaadin-miki
Copy link
Owner

Setting a label position to AFTER_* in components that inherit from CustomField does not work properly (the label stays in front of the component, rather than move after it).

Most likely caused by #493 and incorrect CssImport annotations.
@vaadin-miki vaadin-miki added the bug Something isn't working label Dec 22, 2023
@vaadin-miki vaadin-miki added this to the Next release milestone Dec 22, 2023
@vaadin-miki vaadin-miki self-assigned this Dec 22, 2023
vaadin-miki added a commit that referenced this issue Dec 22, 2023
@vaadin-miki
#511 done
08838b1
@vaadin-miki vaadin-miki mentioned this issue Dec 22, 2023
Merged
vaadin-miki added a commit that referenced this issue Dec 22, 2023
@vaadin-miki
#511 done (#512)
b103a03
vaadin-miki added a commit that referenced this issue Jul 15, 2024
@vaadin-miki
Release 0.19.1 ready (#517)
e2ee389 
* #508 likely done (#509)
* #54 Swedish translation to superdatepickeri18n.properties (#507) (#510)
* #511 done (#512)
* #513 #514 done (#515)
* (bot) release notes updated for 0.19.1
* (bot) version updated to 0.19.1

---------
Co-authored-by: Sebastian Penttinen <31658152+sebastianpenttinen@users.noreply.github.com>
Co-authored-by: sebastianPenttinen <sebastian.penttinen@beanbakers.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaadin-miki vaadin-miki

Labels
bug Something isn't working
Projects
None yet
Milestone
0.19.1 - Bug fixes
Development

Successfully merging a pull request may close this issue.

#511 done vaadin-miki/super-fields
1 participant
@vaadin-miki