Skip to content

Commit

Permalink
S390x: improve performance by skipping Debug Hook if not needed
Browse files Browse the repository at this point in the history
Change-Id: Ib4b2821f2941cdc131f9c75b89a3baced7554f8d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991802
Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#65644}
  • Loading branch information
Milad Farazmand authored and Commit Bot committed Jan 8, 2020
1 parent 4273416 commit d89f4ef
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/codegen/s390/macro-assembler-s390.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1289,8 +1289,8 @@ void MacroAssembler::CheckDebugHook(Register fun, Register new_target,
ExternalReference debug_hook_active =
ExternalReference::debug_hook_on_function_call_address(isolate());
Move(r6, debug_hook_active);
tm(MemOperand(r6), Operand::Zero());
bne(&skip_hook);
tm(MemOperand(r6), Operand(0xFF));
beq(&skip_hook);

{
// Load receiver to pass it later to DebugOnFunctionCall hook.
Expand Down

0 comments on commit d89f4ef

Please sign in to comment.