Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daal4py patches to scikit-learn cause test_dtype_match to fail #86

Open
oleksandr-pavlyk opened this issue Apr 15, 2019 · 0 comments
Open
Labels
bug Something isn't working

Comments

@oleksandr-pavlyk
Copy link
Contributor

With #84 daal4py is used to compute logistic loss and its gradient with solver='newton-cg'. This causes

python -m daal4py -m pytest --pyargs sklearn.linear_model.tests.test_logistic::test_dtype_match -ra

to fail, so it is currently being deselected, see deselected_tests.yaml#L31.

This issue is to document the deselection and the failure:

>       assert_allclose(lr_32.coef_, lr_64.coef_.astype(np.float32), rtol=rtol)
E       AssertionError:
E       Not equal to tolerance rtol=1e-06, atol=0
E
E       Mismatch: 100%
E       Max absolute difference: 0.00011081
E       Max relative difference: 0.00011659
E        x: array([[0.950293, 0.723663]], dtype=float32)
E        y: array([[0.950404, 0.723695]], dtype=float32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants