You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
> > > I think this is a bug in Clang (not only AppleClang): [llvm/llvm-project#61763](https://github.com/llvm/llvm-project/issues/61763)
The bug is fixed in version LLVM 18.1.0.
AppleClang from Xcode 16.2 based on LLVM 17.
I agree that we should just disable these concepts with any Clang for now.
My results of compiling test_blocked_range.cpp on Ubuntu:
Clang 14.0.0 - compiles
Clang 15.0.0 - compiles
Clang 17.0.1 - same compilation error as in MacOS CI above
Clang 18.1.0 - compiles
Clang 19.1.0 - internal compiler error
Should not we then check the clang's version and enable concepts only if the version is not 17 or not 19? We have __TBB_CLANG_VERSION macro.
I agree, we can enable back concepts on the clang versions not affected by the issue described above.
An other option we have is not to disable concepts completely since the issue only affects TBB classes that uses a constrained friend declaration inside (like blocked_range that friends blocked_range2d.
I still propose to keep concepts on clang totally disabled for this release and create a separate issue for enabling it to make sure other fixes introduced in this patch are landed. I still feel that we need to test the potential fix better on different versions of clang on both Linux and MacOS before enabling concepts.
C++20 concepts and TBB APIs constraints are currently disabled on Clang systems due to bug described in the PR above.
We need a stable and tested solution to enable (or partially enable) them on different Clang (Linux and MacOS) systems
The text was updated successfully, but these errors were encountered:
I agree, we can enable back concepts on the clang versions not affected by the issue described above.
An other option we have is not to disable concepts completely since the issue only affects TBB classes that uses a constrained friend declaration inside (like
blocked_range
that friendsblocked_range2d
.I still propose to keep concepts on clang totally disabled for this release and create a separate issue for enabling it to make sure other fixes introduced in this patch are landed. I still feel that we need to test the potential fix better on different versions of clang on both Linux and MacOS before enabling concepts.
Originally posted by @kboyarinov in #1611 (comment)
C++20 concepts and TBB APIs constraints are currently disabled on Clang systems due to bug described in the PR above.
We need a stable and tested solution to enable (or partially enable) them on different Clang (Linux and MacOS) systems
The text was updated successfully, but these errors were encountered: