Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cophenetic distances #102

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Conversation

ayushnag
Copy link

@ayushnag ayushnag commented Feb 4, 2025

Implementation of the cophenetic_distances function in Rust. Also includes bindings

Related Issues

Closes #70

Copy link

deepsource-io bot commented Feb 4, 2025

Here's the code health analysis summary for commits 066968a..0cca04a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

sonarqubecloud bot commented Feb 4, 2025

@ayushnag ayushnag changed the title feat: Cophenetic distances feat: cophenetic distances Feb 4, 2025
@ayushnag
Copy link
Author

ayushnag commented Feb 4, 2025

@madelinegordon One issue is that the existing python tests for this function use the ete3 package. They compare the phylo2vec distance matrix against the one produced by ete3. However we cannot include this package in the Rust tests. Should we come up with some toy vector examples and verify those in the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add cophenetic_distances function to rust and integrate binding
1 participant