fix: sending of batch emails without exposing all recipient emails #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loks0n
approved these changes
Jan 15, 2025
|
It will be done in a separate PR in appwrite repo... (working on it) Till then i think this should be good to merge. created the PR- appwrite/appwrite#9243 |
I'm worried about this being done in the appwrite repo instead of Utopia because that means the behavior of utopia is different based on the adapter you choose. Has this been discussed with anyone else? |
abnegate
reviewed
Jan 28, 2025
|
@abnegate here is how the sendgrid personalizations array looks like now: 
|
|
shifted to this pr here - #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses the data security concerns while sending of batch emails that exposes all the other recipients emails to every recipient.
Test Plan
setup:
mailgun working:
sendgrid working:
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes.