Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename communicator instances #365

Closed
wd15 opened this issue Sep 19, 2014 · 3 comments
Closed

Rename communicator instances #365

wd15 opened this issue Sep 19, 2014 · 3 comments

Comments

@wd15
Copy link
Contributor

wd15 commented Sep 19, 2014

Rename communicator instances from parallel and serial to parallelComm and serialComm respectively.

Calling the parallel comm instance parallel is not really helpful when explaining what it is.

Imported from trac ticket #491, created by wd15 on 01-22-2013 at 11:13, last modified: 01-23-2013 at 12:10

@wd15
Copy link
Contributor Author

wd15 commented Sep 19, 2014

Don't forget to deprecate the parallel and serial names!

Trac comment by wd15 on 01-22-2013 at 11:17

@wd15
Copy link
Contributor Author

wd15 commented Sep 19, 2014

Changes made:

  • Renamed parallel to parallelComm... see 28de7a8
The following changes since commit a72976805bdd3bebf0bd666ee3dbeb11b936a8a3:

  Merge branch 'lsmparse' into develop (2012-12-21 10:24:34 -0500)

are available in the git repository at:


  ssh://git@code.matforge.org/nist/fipy.git ticket491-rename-communicator-instances

for you to fetch changes up to 28de7a8107fbd6ba83fd013db68773919e769b3c:

  Fixing issue #365, renaming `parallel` and `serial` communicators. (2013-01-22 17:32:21 -0500)

----------------------------------------------------------------
Daniel Wheeler (1):
Fixing issue #365, renaming `parallel` and `serial` communicators.

 examples/diffusion/anisotropy.py                             |    2 +-
 examples/levelSet/advection/mesh1D.py                        |    4 ++--
 examples/levelSet/advection/trench.py                        |    4 ++--
 examples/levelSet/distanceFunction/circle.py                 |    4 ++--
 examples/levelSet/distanceFunction/interior.py               |    4 ++--
 examples/levelSet/distanceFunction/mesh1D.py                 |    4 ++--
 examples/levelSet/electroChem/adsorbingSurfactantEquation.py |    8 ++++----
 examples/levelSet/electroChem/adsorption.py                  |    4 ++--
 examples/levelSet/electroChem/gapFillMesh.py                 |   10 +++++-----
 examples/levelSet/electroChem/howToWriteAScript.py           |    4 ++--
 examples/levelSet/electroChem/metalIonDiffusionEquation.py   |    8 ++++----
 examples/levelSet/electroChem/simpleTrenchSystem.py          |    4 ++--
 examples/levelSet/electroChem/trenchMesh.py                  |    8 ++++----
 examples/levelSet/surfactant/expandingCircle.py              |    4 ++--
 examples/parallel.py                                         |    6 +++---
 fipy/__init__.py                                             |   20 ++++++++++----------
 fipy/boundaryConditions/boundaryCondition.py                 |    4 ++--
 fipy/matrices/pysparseMatrix.py                              |    8 ++++----
 fipy/matrices/scipyMatrix.py                                 |    4 ++--
 fipy/matrices/trilinosMatrix.py                              |   20 ++++++++++----------
 fipy/meshes/abstractMesh.py                                  |    2 +-
 fipy/meshes/cylindricalGrid1D.py                             |    4 ++--
 fipy/meshes/cylindricalGrid2D.py                             |    4 ++--
 fipy/meshes/cylindricalUniformGrid1D.py                      |    4 ++--
 fipy/meshes/cylindricalUniformGrid2D.py                      |    4 ++--
 fipy/meshes/factoryMeshes.py                                 |   37 +++++++++++++++++++------------------
 fipy/meshes/gmshMesh.py                                      |   66 +++++++++++++++++++++++++++++++++---------------------------------
 fipy/meshes/grid1D.py                                        |    4 ++--
 fipy/meshes/grid2D.py                                        |    4 ++--
 fipy/meshes/grid3D.py                                        |    4 ++--
 fipy/meshes/mesh.py                                          |    4 ++--
 fipy/meshes/mesh1D.py                                        |    4 ++--
 fipy/meshes/mesh2D.py                                        |    4 ++--
 fipy/meshes/periodicGrid1D.py                                |    1 -
 fipy/meshes/periodicGrid2D.py                                |    4 ++--
 fipy/meshes/uniformGrid1D.py                                 |    4 ++--
 fipy/meshes/uniformGrid2D.py                                 |    8 ++++----
 fipy/meshes/uniformGrid3D.py                                 |    8 ++++----
 fipy/solvers/__init__.py                                     |   14 +++++++-------
 fipy/solvers/trilinos/trilinosNonlinearSolver.py             |    4 ++--
 fipy/tools/__init__.py                                       |   37 ++++++++++++++++++++-----------------
 fipy/tools/debug.py                                          |   12 ++++++------
 fipy/tools/dump.py                                           |    6 +++---
 fipy/variables/distanceVariable.py                           |   14 +++++++-------
 fipy/variables/noiseVariable.py                              |    6 +++---
 fipy/viewers/viewer.py                                       |    8 ++++----
 46 files changed, 204 insertions(+), 201 deletions(-)

Trac comment by wd15 on 01-22-2013 at 17:52

@guyer
Copy link
Member

guyer commented Sep 19, 2014

Replying to wd15:

Changes made:

  • Renamed parallel to parallelComm... see 28de7a8
The following changes since commit a72976805bdd3bebf0bd666ee3dbeb11b936a8a3:

  Merge branch 'lsmparse' into develop (2012-12-21 10:24:34 -0500)

are available in the git repository at:


  ssh://git@code.matforge.org/nist/fipy.git ticket491-rename-communicator-instances

for you to fetch changes up to 28de7a8107fbd6ba83fd013db68773919e769b3c:

  Fixing issue #365, renaming `parallel` and `serial` communicators. (2013-01-22 17:32:21 -0500)

pull request merged to develop at 581239c

Trac comment by guyer on 01-23-2013 at 12:10

@wd15 wd15 closed this as completed Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants