Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SvnToGit clean up #338

Closed
wd15 opened this issue Sep 19, 2014 · 3 comments
Closed

SvnToGit clean up #338

wd15 opened this issue Sep 19, 2014 · 3 comments

Comments

@wd15
Copy link
Contributor

wd15 commented Sep 19, 2014

@wd15
Copy link
Contributor Author

wd15 commented Sep 19, 2014

Pushed version number changes to genie see e04c68a497

The following changes since commit 9784a7a6c5ebda98d5a7292565ac8dc6a944c6b4:

  merged [documentation](../tree/documentation)@5299 to [trunk](../tree/master/trunk)@5299 (2012-08-16 15:37:48 +0000)

are available in the git repository at:

  ssh://genie.X.X//users/wd15/git/fipy ticket461-svn2git-version-number-rebase

Daniel Wheeler (1):
SvnToGit cleanup -- issue #338 -- fipy version obtained with git

 setup.py |   37 ++++++++++++-------------------------
 1 files changed, 12 insertions(+), 25 deletions(-)

Trac comment by wd15 on 09-04-2012 at 12:43

@guyer
Copy link
Member

guyer commented Sep 19, 2014

I don't know that the -dev substitution is necessary, and perhaps line 243

print(" --- Could not run git describe --- ")

should raise a warning, instead?

Otherwise, this looks fine.

Trac comment by guyer on 09-04-2012 at 13:55

@wd15
Copy link
Contributor Author

wd15 commented Sep 19, 2014

Replying to guyer:

I don't know that the -dev substitution is necessary, and perhaps line 243

Keeping -dev to keep backward compatibility and it's what numpy does.

print(" --- Could not run git describe --- ")

should raise a warning, instead?

Changed to a warnings.warn(...).

Otherwise, this looks fine.

Merged into the develop branch with 2443725

Trac comment by wd15 on 09-04-2012 at 15:40

@wd15 wd15 closed this as completed Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants