Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make more state vars (and perhaps functions?) public #74

Closed
jacob-eliosoff opened this issue Dec 16, 2020 · 1 comment
Closed

Make more state vars (and perhaps functions?) public #74

jacob-eliosoff opened this issue Dec 16, 2020 · 1 comment

Comments

@jacob-eliosoff
Copy link
Collaborator

Eg storedPriceA/storedPriceB in OurUniwapV2TWAPOracle. I made those private to try to save gas but I don't even think it does? Anyway not worth it, better to expose this stuff for debugging etc
@jacob-eliosoff
Copy link
Collaborator Author

I did this, making a bunch of vars and fns public. (Though it has kind of cluttered up the "read contract" view on Etherscan - we could consider making some of them private/internal again. See also this interesting discussion on default visibility: ethereum/solidity#2608)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacob-eliosoff