Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Markdown rendering: underscores don't render as italics or bold; links within italics or bold fail to render (more issues noted in comments) #18

Open
samglover opened this issue Mar 8, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@samglover
Copy link

Describe the bug

In Markdown, text surrounded by asterisks or underscores should render as italics (single asterisks/underscores) or bold (double).

Both of these strings should render as italics: *italics* _italics_

And these strings should render in italics, with a link:

*See: [Link](https://example.com)*
_See: [Link](https://example.com)_

Both of these strings should render as bold: **bold** __bold__

And these strings should render in bold, with a link:

**See: [Link](https://example.com)**
__See: [Link](https://example.com)__

They render properly in GitHub issues, for example:

italics
italics
See: Link
See: Link
bold
bold
See: Link
See: Link

However, in Memos they do not:

Image

Steps to reproduce

Paste the following into a note, then click Save:

*italics*
_italics_
*See: [Link](https://example.com)*
_See: [Link](https://example.com)_
**bold**
__bold__
**See: [Link](https://example.com)**
__See: [Link](https://example.com)__

The version of Memos you're using

v0.24.0

Screenshots or additional context

No response

@samglover samglover added the bug Something isn't working label Mar 8, 2025
@samglover samglover changed the title Inconsistent Markdown rendering (underscores don't render as italics or bold; fails to render links within italics Inconsistent Markdown rendering: underscores don't render as italics or bold; links within italics or bold fail to render Mar 8, 2025
@samglover
Copy link
Author

Found another one. HTML is valid in Markdown, so I tried <small>See: [Example](https://example.com)</small>. GitHub strips the <small> tags, which is OK: See: Example in GitHub.

Memos is weird:

Image

Not sure what's going on there.

@samglover
Copy link
Author

Here's another issue, with blockquote rendering. This should all render as one blockquote:

> This
> 
> should all be
> one blockquote

Here is how GitHub renders it:

This

should all be
one blockquote

Here is what it looks like in Memos:

Image

@samglover samglover changed the title Inconsistent Markdown rendering: underscores don't render as italics or bold; links within italics or bold fail to render Inconsistent Markdown rendering: underscores don't render as italics or bold; links within italics or bold fail to render (more issues noted in comments) Mar 8, 2025
@johnnyjoygh
Copy link
Contributor

FYI, the markdown syntax of memos is a subset of GFW(GitHub Flavored Markdown), so we will gradually implement other syntaxes based on demand.

@johnnyjoygh johnnyjoygh added enhancement New feature or request and removed bug Something isn't working labels Mar 9, 2025
@johnnyjoygh johnnyjoygh transferred this issue from usememos/memos Mar 9, 2025
@johnnyjoygh johnnyjoygh self-assigned this Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants