Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect incompatible version of ink #754

Closed
ascjones opened this issue Sep 22, 2022 · 0 comments · Fixed by #1334
Closed

Detect incompatible version of ink #754

ascjones opened this issue Sep 22, 2022 · 0 comments · Fixed by #1334
Assignees
@smiasojed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ascjones
Copy link
Collaborator

The 2.0.0 release of cargo-contract will only be compatible with 4.x releases of ink, so 3.x releases and earlier will be incompatible.

We should add a check which reads the version of the ink dependency in the contract and if it is incompatible, provide the user with a suggestion to either

  1. Upgrade their contract to 4.0
  2. Install an earlier 1.x release of cargo-contract

Could also provide a link to docs with a table of compatible cargo-contract -> ink -> pallet-contracts combinations.
@ascjones ascjones mentioned this issue Sep 22, 2022
Merged
@HCastano HCastano added the enhancement New feature or request label Feb 9, 2023
@cmichi cmichi added the good first issue Good for newcomers label Feb 24, 2023
@smiasojed smiasojed mentioned this issue Sep 25, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smiasojed smiasojed

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add contract's ink! compatibility check use-ink/cargo-contract
4 participants
@ascjones @cmichi @HCastano @smiasojed