Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before contract upload/instantiate: verify that node types match contract types #1167

Closed
cmichi opened this issue Jun 20, 2023 · 1 comment · Fixed by #1377
Closed

Before contract upload/instantiate: verify that node types match contract types #1167

cmichi opened this issue Jun 20, 2023 · 1 comment · Fixed by #1377
Assignees
Labels
enhancement New feature or request

Comments

@cmichi
Copy link
Collaborator

cmichi commented Jun 20, 2023

With use-ink/ink#1695 the environmental types of a contract are now persisted to its metadata. Before a contract is uploaded/instantiated to a chain we should conduct a verification that the contract's types actually match the ones from the node metadata.

@cmichi cmichi added the enhancement New feature or request label Jun 20, 2023
@cmichi cmichi moved this to Todo in OpenZeppelin ↔ ink! Jun 20, 2023
@SkymanOne
Copy link
Contributor

SkymanOne commented Aug 7, 2023

The Substrate Node's does not expose those type in plain. We need first to figure out how to expose those types in the generated metadata using subxt. This requires some work to be done in Substrate's metadata IR to expose those types, then the changes need to be propagated to subxt before we can tackle this isues.

@SkymanOne SkymanOne added the blocked This task is blocked until blockers are resolved. label Aug 8, 2023
@SkymanOne SkymanOne moved this from Todo to In Progress in OpenZeppelin ↔ ink! Aug 14, 2023
@SkymanOne SkymanOne removed the blocked This task is blocked until blockers are resolved. label Oct 20, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenZeppelin ↔ ink! Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants