Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pallet contracts primitives with new generic #1064

Closed
juangirini opened this issue Apr 6, 2023 · 0 comments · Fixed by #1149
Closed

Update pallet contracts primitives with new generic #1064

juangirini opened this issue Apr 6, 2023 · 0 comments · Fixed by #1149
Labels
good first issue Good for newcomers

Comments

@juangirini
Copy link

juangirini commented Apr 6, 2023 •
edited
Loading

As a result of this Contract's PR ContractResult, ContractInstantiateResult and ContractExecResult now expect a new EventRecord generic that needs to be added.

Also the pallet_contracts::ContractsApi trait now requires this extra generic and needs to be updated like here.
@juangirini juangirini added good first issue Good for newcomers blocked This task is blocked until blockers are resolved. labels Apr 6, 2023
@juangirini juangirini mentioned this issue Apr 6, 2023
Merged
@juangirini juangirini removed the blocked This task is blocked until blockers are resolved. label May 5, 2023
@ascjones ascjones mentioned this issue Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update subxt and substrate dependencies use-ink/cargo-contract
1 participant
@juangirini