Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate vets.gov-isms in form submit and file upload #211

Closed
dmethvin-gov opened this issue Aug 8, 2018 · 6 comments · Fixed by #289
Closed

Eliminate vets.gov-isms in form submit and file upload #211

dmethvin-gov opened this issue Aug 8, 2018 · 6 comments · Fixed by #289
Assignees
Labels
[practice] engineering Engineering related work
Milestone

Comments

@dmethvin-gov
Copy link
Contributor

There are still quite a few things that depend on server behavior specific to vets.gov like the use of req.setRequestHeader('X-Key-Inflection', 'camel') in actions.js that expects the use of particular Rails middleware. Since servers and their configurations are so different this might be a good place to just have the app pass us a callback in formConfig. We pass it the formData and they use to submit the form, serializing it whatever way they want (JSON, XML, form-urlencoded). The same goes for file uploads.

@dmethvin-gov dmethvin-gov added the [practice] engineering Engineering related work label Aug 9, 2018
@dmethvin-gov
Copy link
Contributor Author

Adding the va-growable-* classes in m-schemaform.scss. I suppose these might just need to be renamed to be generic but they may be defining some style we want to modify.

@jcmeloni-usds
Copy link
Contributor

@dmethvin-gov Confirming this is still ongoing -- correct?

@dmethvin-gov
Copy link
Contributor Author

Yes, I'll be making some changes once the new router lands.

@jcmeloni-usds jcmeloni-usds added this to the 2.0.0-alpha.2 milestone Sep 19, 2018
@jcmeloni-usds
Copy link
Contributor

Ok, moved to phase 2 and the 2.0.0-alpha1 milestone

@annekainicUSDS
Copy link
Contributor

Another thing to add here: the "Submit again" button that only appears in dev and staging, we want to remove that now.

@dmethvin-gov
Copy link
Contributor Author

Adding the rework of stringifyFormReplacer from #259, which currently has special case processing for various widgets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[practice] engineering Engineering related work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants