Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter errors in tests #57

Open
rhys-vdw opened this issue Mar 2, 2018 · 0 comments
Open

Fix linter errors in tests #57

rhys-vdw opened this issue Mar 2, 2018 · 0 comments
Labels
help wanted

Comments

@rhys-vdw
Copy link
Collaborator

rhys-vdw commented Mar 2, 2018 •
edited
Loading

Quick fix option

Add https://www.npmjs.com/package/eslint-plugin-jest and in the test file:

/* eslint-env jest/globals */

So that we don't get undefined errors for all the globals defined by jest.

Better option

Use https://github.com/substack/tape instead which doesn't modify globals.
@rhys-vdw rhys-vdw mentioned this issue Mar 2, 2018
Merged
@rhys-vdw rhys-vdw changed the title Configure ESLint for jest Fix linter errors in tests Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhys-vdw