Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

>= v2.7.0 can't be used with GPL2-incompatible projects #1404

Closed
AkihiroSuda opened this issue May 23, 2022 · 2 comments · Fixed by #1405
Closed

>= v2.7.0 can't be used with GPL2-incompatible projects #1404

AkihiroSuda opened this issue May 23, 2022 · 2 comments · Fixed by #1405
Labels
area/v2 relates to / is being considered for v2 kind/discussion is for discussion
Milestone
Release 2.x

Comments

@AkihiroSuda
Copy link
Contributor

cli/go.mod

Line 7 in e770ee9

github.com/antzucaro/matchr v0.0.0-20210222213004-b04723ef80f0

I saw urfave/cli v2.7.0 introduced a GPL2 dependency: https://github.com/antzucaro/matchr/blob/master/COPYING.txt

Would it be possible to replace (or relicense) the dependency?
Otherwise urfave/cli can no longer be used in GPL2-incompatible (e.g., Apache License 2.0) projects AFAICS.
This was referenced May 23, 2022
Closed
Merged
Merged
@meatballhat
Copy link
Member

@AkihiroSuda Would it be acceptable to introduce a build tag to exclude this dependency, e.g. -tags urfave_cli_no_suggest?

@meatballhat meatballhat added kind/discussion is for discussion area/v2 relates to / is being considered for v2 labels May 23, 2022
@meatballhat meatballhat added this to the Release 2.x milestone May 23, 2022
This was referenced May 23, 2022
Closed
Closed
Merged
@AkihiroSuda
Copy link
Contributor Author

Opened PR

Build tags are not preferable IMHO as it complicates downstream Makefiles and may produce false-positives with license validation tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/v2 relates to / is being considered for v2 kind/discussion is for discussion
Projects
None yet
Milestone
Release 2.x
Development

Successfully merging a pull request may close this issue.

Remove GPL2 dependency introduced in v2.7.0 AkihiroSuda/urfave-cli
2 participants
@meatballhat @AkihiroSuda