Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert FilePath field in flags from string to string array #1166

Closed
3 tasks done
kneal opened this issue Jul 27, 2020 · 3 comments · Fixed by #1601
Closed
3 tasks done

Convert FilePath field in flags from string to string array #1166

kneal opened this issue Jul 27, 2020 · 3 comments · Fixed by #1601
Labels
area/v3 relates to / is being considered for v3 kind/feature describes a code enhancement / feature request status/triage maintainers still need to look into this
Milestone

Comments

@kneal
Copy link

kneal commented Jul 27, 2020

Checklist

  • Are you running the latest v2 release? The list of releases is here.
  • Did you check the manual for your release? The v2 manual is here
  • Did you perform a search about this feature? Here's the Github guide about searching.

What problem does this solve?

A clear and concise description of what problem this feature would solve. For example:

  • I am suggesting the FilePath option in all flags should be converted to a string array.

Solution description

A detailed description of what you want to happen.

Today, the FilePath option for all flags is a string. You can use it as an array by doing comma-separated paths within the field. In v1 EnvVar and FilePath were consistent where you could specify an array of environment names separated by commas. I believe the value in converting FilePath to a string array is to maintain consistency for the users setting defaults on the flag options.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Another option I see is leaving it the way it is but one could argue the user experience isn't consistent between setting config for EnvVar and FilePath.

@kneal kneal added area/v2 relates to / is being considered for v2 status/triage maintainers still need to look into this labels Jul 27, 2020
@kneal kneal changed the title v2 feature: ( convert FilePath field in flags from string to string array ) v2 feature: convert FilePath field in flags from string to string array Jul 28, 2020
@stale
Copy link

stale bot commented Oct 27, 2020

This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else.

@stale stale bot added the status/stale stale due to the age of it's last update label Oct 27, 2020
@stale
Copy link

stale bot commented Nov 26, 2020

Closing this as it has become stale.

@stale stale bot closed this as completed Nov 26, 2020
@meatballhat meatballhat reopened this Apr 22, 2022
@meatballhat meatballhat removed the status/stale stale due to the age of it's last update label Apr 22, 2022
@meatballhat meatballhat changed the title v2 feature: convert FilePath field in flags from string to string array Convert FilePath field in flags from string to string array Apr 23, 2022
@meatballhat meatballhat added the kind/feature describes a code enhancement / feature request label Apr 23, 2022
@dearchap
Copy link
Contributor

@kneal do you have any examples that utilize this behavior? Since this is a breaking change I would likely target for v3

@dearchap dearchap added area/v3 relates to / is being considered for v3 and removed area/v2 relates to / is being considered for v2 labels Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v3 relates to / is being considered for v3 kind/feature describes a code enhancement / feature request status/triage maintainers still need to look into this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants