Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in restart execution when /dev/shm is used #12

Open
qtcwt opened this issue May 16, 2020 · 1 comment
Open

Bugs in restart execution when /dev/shm is used #12

qtcwt opened this issue May 16, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@qtcwt
Copy link
Member

qtcwt commented May 16, 2020

When /dev/shm is used (i.e., SHM_SIMULATING is defined), at the end of a restart execution when cached blocks are given back to their superblocks, the superblock pointer in their descriptor is NULL.

It could be due to incorrect write-back, or there's something missed for restart.
It shouldn't be due to page caching of mmap whose backing file is in /dev/shm, since explicitly issuing a msync before munmap doesn't solve the issue.
However, the issue disappears when /mnt/pmem and DAX-mmap is used.

The branch of test has a toy program that can trigger this bug.

Also, another bug was reported that RP_free causes a segfault in a similar scenario---in a restart execution with SHM_SIMULATING, and disappears when /mnt/pmem is used.

@qtcwt qtcwt self-assigned this May 16, 2020
@qtcwt qtcwt changed the title Content in descriptor is 0 after recovery when /dev/shm is used Bug in restart execution when /dev/shm is used May 16, 2020
@qtcwt qtcwt changed the title Bug in restart execution when /dev/shm is used Bugs in restart execution when /dev/shm is used May 16, 2020
@qtcwt
Copy link
Member Author

qtcwt commented May 16, 2020

Both bugs are triggered despite the proper call to RP_close at the end of the previous execution.

@qtcwt qtcwt linked a pull request Aug 6, 2020 that will close this issue
@qtcwt qtcwt added the bug Something isn't working label Nov 4, 2020
@qtcwt qtcwt added this to the 2.0 milestone Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant