Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure reopt can only be run with reopt files & data #292

Closed
vtnate opened this issue Feb 11, 2022 · 1 comment · Fixed by #299
Closed

Ensure reopt can only be run with reopt files & data #292

vtnate opened this issue Feb 11, 2022 · 1 comment · Fixed by #299
Assignees
Labels
enhancement New feature or request

Comments

@vtnate
Copy link
Collaborator

vtnate commented Feb 11, 2022

Is your feature request related to a problem? Please describe.
It's possible to reopt post-process when you haven't run with reopt, which leads to inaccurate results

Describe the solution you'd like
Gracefully ensure reopt runs with the proper information.

Additional context
Zahra ran into this issue

@vtnate vtnate added the enhancement New feature or request label Feb 11, 2022
@vtnate vtnate self-assigned this Feb 11, 2022
@vtnate
Copy link
Collaborator Author

vtnate commented Feb 14, 2022

The run command doesn't use reopt, though the reopt post-processor needs the extra column in the scenario file to determine the correct assumptions file for each feature. We can simplify (eliminate 2 cli options, eliminate reopt_scenario_file) at the process command by:

  1. copying the example assumptions files when the user requests a reopt post-processing
  2. adding the assumptions file column to the existing scenario_file instead of making a new scenario_file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant