Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Useless length parameter in ComputeHash for ReadOnlySpan<byte> #27

Open
Crauzer opened this issue Feb 3, 2023 · 0 comments
Open

Useless length parameter in ComputeHash for ReadOnlySpan<byte> #27

Crauzer opened this issue Feb 3, 2023 · 0 comments

Comments

@Crauzer
Copy link

Crauzer commented Feb 3, 2023

xxHash/src/Standart.Hash.xxHash/xxHash64.cs

Line 167 in 6b20e7f

public static unsafe ulong ComputeHash(ReadOnlySpan<byte> data, int length, ulong seed = 0)

The length parameter makes no sense in this context. The user is already passing in a Span object which has a Length property that can be used instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Crauzer