feat: add ModelTableExpr to TruncateTableQuery #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmihailenco
reviewed
Apr 2, 2024
| _, err := m.db.NewTruncateTable().TableExpr(m.table).Exec(ctx) | ||
| _, err := m.db.NewTruncateTable(). | ||
| ModelTableExpr(m.table). | ||
| Exec(ctx) |
There was a problem hiding this comment.
This does not look right, because there is no Model call. Could you revert it?
There was a problem hiding this comment.
@vmihailenco
Thanks for the reply.
Referring to other implementations, I decided that it would be better to call a Model method than to revert.
I would appreciate it if you could check the following commit again. 27193c3
JunNishimura
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #960.
I implemented a ModelTableExpr method in TruncateTableQuery as well, referring to CreateTableQuery, etc.
The Document stated that ModelTableExpr can be used, but it is not implemented actually, so I made this modification.
I would appreciate it if you check it out!