Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SYS-31): add SLA Pages resource #103

Merged
merged 1 commit into from
Aug 29, 2024
Merged

feat(SYS-31): add SLA Pages resource #103

merged 1 commit into from
Aug 29, 2024

Conversation

gigovich
Copy link
Contributor

No description provided.

bazzisoft
bazzisoft approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@bazzisoft bazzisoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gigovich I'm very unfamiliar with TF providers so my review is probably of limited value - feel free to wait for @mikluko for another look if you think it's necessary.

From the Go side I couldn't fault the code and it all makes sense to me, as much as I understand of it.

@gigovich gigovich force-pushed the givi-sla-report-sys-31 branch 3 times, most recently from 9170eee to 2303164 Compare August 26, 2024 14:40
@gigovich gigovich merged commit fb8b790 into develop Aug 29, 2024
5 checks passed
@gigovich gigovich deleted the givi-sla-report-sys-31 branch August 29, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikluko mikluko mikluko approved these changes

@bazzisoft bazzisoft bazzisoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gigovich @mikluko @bazzisoft