-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving documentation CI workflows #922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally good, but I have some doubts about the token permissions when dispatching to the other repo.
I think that using the repository_dispatch event may be safer
Codecov Report
@@ Coverage Diff @@
## main #922 +/- ##
==========================================
- Coverage 81.78% 80.90% -0.89%
==========================================
Files 85 85
Lines 2652 2697 +45
Branches 507 557 +50
==========================================
+ Hits 2169 2182 +13
- Misses 481 515 +34
+ Partials 2 0 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one last thing to do, please check the URL for triggering the repository dispatch.
I added a suggestion with what I believe to be the right URL.
Everything else looks great!
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
veramo-website
toveramo
veramo-website
workflow will run when code is pushed tomain