Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: didcomm messaging using did:ethr #744

Merged
merged 6 commits into from
Nov 11, 2021
Merged

Conversation

mirceanis
Copy link
Member

@mirceanis mirceanis commented Nov 11, 2021

fixes #743
relates to #733

  • a new test suite that uses ganache to test some did:ethr updates through Veramo
  • some fixes in did-comm/utils for comparing secp256k1 signing keys
  • updated to latest @ethersproject & ethr-did libs to support X25519 keyAgreement keys
  • documented and renamed test suites for better readability

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #744 (e713d6f) into next (88264db) will increase coverage by 14.20%.
The diff coverage is 81.60%.

@@             Coverage Diff             @@
##             next     #744       +/-   ##
===========================================
+ Coverage   67.58%   81.78%   +14.20%     
===========================================
  Files          62       85       +23     
  Lines        1530     2652     +1122     
  Branches      247      507      +260     
===========================================
+ Hits         1034     2169     +1135     
- Misses        400      481       +81     
+ Partials       96        2       -94     

Copy link
Contributor

@simonas-notcat simonas-notcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@mirceanis mirceanis merged commit 1be5e04 into next Nov 11, 2021
@mirceanis mirceanis deleted the 743-fix-ethr-did-didcomm-flow branch November 11, 2021 15:15
@mirceanis mirceanis mentioned this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

did:ethr provider addKey with X25519 key type does not add keyAgreement section to DID doc
2 participants