Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(did-ethr-provider): allow initialization with chainId number #678

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

mirceanis
Copy link
Member

This allows numbers to be used for the network parameter of EthrDidProvider.

'did:ethr:421611': new EthrDIDProvider({
  network: 421611,
  // ...
}),

This is a small workaround until EthrDidControler API can be improved to accept more flexible configuration.
fixes #677

I also rearranged some of the imports in the integration tests for easier development.

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #678 (1433c00) into next (88264db) will increase coverage by 11.47%.
The diff coverage is 74.48%.

@@             Coverage Diff             @@
##             next     #678       +/-   ##
===========================================
+ Coverage   67.58%   79.06%   +11.47%     
===========================================
  Files          62       78       +16     
  Lines        1530     2364      +834     
  Branches      247      415      +168     
===========================================
+ Hits         1034     1869      +835     
- Misses        400      493       +93     
+ Partials       96        2       -94     

@mirceanis mirceanis merged commit 38cd0ae into next Aug 25, 2021
@mirceanis mirceanis deleted the 677-fix-did-ethr-provider-chain-id branch August 25, 2021 13:53
@mirceanis mirceanis mentioned this pull request Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth-did-provider in-flexible network property
2 participants