fix(data-store): match claims by credential hash when deleting credential #1270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this PR fixing
fixes #1269
What is being changed
When deleting a credential, the corresponding claims are matched by the credential
hash
(internally computed) instead of the credentialid
which is optional.Quality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.Details
I included the tests in the
localJsonStoreAgent
test suite as well to ensure similar behavior.The
@veramo/data-store-json
did not manifest the same bug, but I added it to check for regressions.This is a hotfix that should be release before the next major release