Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace text-table with markdown-table #79

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Conversation

ambar
Copy link
Contributor

@ambar ambar commented Jan 18, 2021

Markdown's more compact, has rules, and can be used in GitHub/GitLab comments.

Size

  • text-table min size
  • markdown-table min size

Before

Profile results for Server

> Stats by Ext

Ext    Requests  Time   Time/Request  Description

js     5582      6s     989μs         JavaScript files

css    2063      2s     960μs         css files

svg    323       499ms  2ms           svg files

png    622       451ms  725μs         png files

gif    14        6ms    413μs         gif files

jpg    35        5ms    139μs         jpg files

md     1         1ms    1ms           md files

Total  8640      8s

...

After

Profile results for Server

> Stats by Ext

| Ext   | Requests | Time  | Time/Request | Description      |
| ----- | -------- | ----- | ------------ | ---------------- |
| js    | 5393     | 5s    | 990μs        | JavaScript files |
| css   | 2313     | 2s    | 1ms          | css files        |
| svg   | 316      | 499ms | 2ms          | svg files        |
| md    | 1        | 673μs | 673μs        | md files         |
| png   | 581      | 493ms | 848μs        | png files        |
| jpg   | 36       | 17ms  | 477μs        | jpg files        |
| gif   | 9        | 8ms   | 834μs        | gif files        |
| Total | 8649     | 9s    |              |                  |

...

renders to comment:

Stats by Ext

Ext Requests Time Time/Request Description
js 5393 5s 990μs JavaScript files
css 2313 2s 1ms css files
svg 316 499ms 2ms svg files
md 1 673μs 673μs md files
png 581 493ms 848μs png files
jpg 36 17ms 477μs jpg files
gif 9 8ms 834μs gif files
Total 8649 9s

@pi0 pi0 merged commit 457037a into unjs:master Nov 5, 2021
@pi0
Copy link
Member

pi0 commented Nov 5, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants