Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle mount overrides #45

Merged
merged 5 commits into from
May 2, 2022
Merged

fix: handle mount overrides #45

merged 5 commits into from
May 2, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 2, 2022 •
edited
Loading

Resolves #27

This PR includes two important fixes when a mount is shadowing parent (/mnt mounting on / when main mount has keys under mnt: namespace)

  • Avoid returning parent keys with getKeys
  • Avoid calling clear on the entire parent!

@pi0 pi0 self-assigned this May 2, 2022
@pi0 pi0 marked this pull request as ready for review May 2, 2022 13:30
@pi0 pi0 merged commit 092e539 into main May 2, 2022
@pi0 pi0 deleted the fix/mount-override branch May 2, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pi0 pi0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

conflict between mounts in getKeys
1 participant
@pi0