Skip to content

Conversation

masatake
Copy link
Member

Fixed #4227

Copy link

codecov bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.84%. Comparing base (fccad9b) to head (2cfc884).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
parsers/jscript.c 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4228   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files         242      242           
  Lines       62592    62601    +9     
=======================================
+ Hits        53729    53737    +8     
- Misses       8863     8864    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masatake masatake requested a review from Copilot April 13, 2025 10:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • Units/parser-javascript.r/shift-op-jsx.d/README: Language not supported
  • Units/parser-javascript.r/shift-op-jsx.d/args.ctags: Language not supported
Comments suppressed due to low confidence (1)

parsers/jscript.c:3820

  • [nitpick] The comment contains a grammatical error; consider changing 'functions called from this functions' to 'functions called from this function'.
 * and functions called from this functions).

Fixed universal-ctags#4227.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
This is an alternative way to fix universal-ctags#4227.
However, this is not an essential way.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake masatake force-pushed the javascript--shift-op-and-jsx branch from 1412d02 to 2cfc884 Compare April 13, 2025 10:10
@masatake masatake requested a review from Copilot April 13, 2025 10:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • Units/parser-javascript.r/shift-op-jsx.d/README: Language not supported
  • Units/parser-javascript.r/shift-op-jsx.d/args.ctags: Language not supported
Comments suppressed due to low confidence (1)

parsers/jscript.c:1219

  • [nitpick] Consider renaming the variable 'd' to a more descriptive name (e.g., 'nextChar') to improve code clarity.
int d = getcFromInputFile ();

@masatake masatake merged commit 00ae476 into universal-ctags:master Apr 13, 2025
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaScript: Segfault on jQuery v1.11.0
1 participant