-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tmain: Fix make distcheck
#2297
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2297 +/- ##
==========================================
+ Coverage 86.19% 86.19% +<.01%
==========================================
Files 177 177
Lines 35852 35852
==========================================
+ Hits 30901 30904 +3
+ Misses 4951 4948 -3
Continue to review full report at Codecov.
|
55d0f73
to
7081824
Compare
Still this error is shown:
|
7081824
to
a368182
Compare
`make distcheck` sets the source directories readonly. So, temporary files or output files should be written in $BUILDDIR.
Add -f option to rm. This is needed for `make distcheck`.
Error was occurred when removing readonly files.
`make distcheck` fails without this.
a368182
to
61ddb9b
Compare
I focus only on Tmain, units and tlib in this PR. |
@k-takata, do you use misc/review? It may help you in test case improvements. If you got a failure in units or tmain, run the script. |
Oh, I haven't used it. I will try. |
make distcheck
sets the source directories readonly. So, temporary files or output files should be written in $BUILDDIR. Otherwise, tests will fail with permission errors.make distcheck
is important when we create a release.