Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tmain: Fix make distcheck #2297

Merged
merged 4 commits into from
Nov 3, 2019
Merged

Conversation

k-takata
Copy link
Member

@k-takata k-takata commented Nov 2, 2019

make distcheck sets the source directories readonly. So, temporary files or output files should be written in $BUILDDIR. Otherwise, tests will fail with permission errors.

make distcheck is important when we create a release.

@coveralls
Copy link

coveralls commented Nov 2, 2019

Coverage Status

Coverage increased (+0.008%) to 86.32% when pulling 61ddb9b on k-takata:fix-distcheck into 19df463 on universal-ctags:master.

@codecov-io
Copy link

codecov-io commented Nov 2, 2019

Codecov Report

Merging #2297 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2297      +/-   ##
==========================================
+ Coverage   86.19%   86.19%   +<.01%     
==========================================
  Files         177      177              
  Lines       35852    35852              
==========================================
+ Hits        30901    30904       +3     
+ Misses       4951     4948       -3
Impacted Files Coverage Δ
main/routines.c 80.97% <0%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19df463...61ddb9b. Read the comment docs.

@k-takata k-takata force-pushed the fix-distcheck branch 4 times, most recently from 55d0f73 to 7081824 Compare November 2, 2019 16:43
@k-takata
Copy link
Member Author

k-takata commented Nov 2, 2019

Still this error is shown:

ERROR: files left in build directory after distclean:
./optlib/RSpec.c
./optlib/cmake.c
./optlib/ctags-optlib.c
./optlib/elixir.c
./optlib/elm.c
./optlib/gdbinit.c
./optlib/inko.c
./optlib/man.c
./optlib/markdown.c
./optlib/passwd.c
./optlib/pod.c
./optlib/puppetManifest.c
./optlib/qemuhx.c
./optlib/scss.c
./optlib/systemtap.c
./peg/varlink.c
./peg/varlink.h
Makefile:4888: recipe for target 'distcleancheck' failed

`make distcheck` sets the source directories readonly. So, temporary
files or output files should be written in $BUILDDIR.
Add -f option to rm. This is needed for `make distcheck`.
Error was occurred when removing readonly files.
`make distcheck` fails without this.
@k-takata
Copy link
Member Author

k-takata commented Nov 2, 2019

I focus only on Tmain, units and tlib in this PR.
I will create another PR for the issue I wrote above that target 'distcleancheck' fails.

@masatake
Copy link
Member

masatake commented Nov 3, 2019

@k-takata, do you use misc/review?
If not, try it. I believe you like it.

It may help you in test case improvements.

If you got a failure in units or tmain, run the script.
You can inspect a test case and its result interactively.

@k-takata
Copy link
Member Author

k-takata commented Nov 3, 2019

Oh, I haven't used it. I will try.

@k-takata k-takata merged commit 75b853b into universal-ctags:master Nov 3, 2019
@k-takata k-takata deleted the fix-distcheck branch November 3, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants