PowerShell: new parser imported from Geany #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request adds one of the extra parsers we have in Geany except those defined in c.c and except the markdown parser which is readLine() based and not really superior to the regex-based parser ctags uses (we should probably use the ctags parser in Geany instead). The added a parser is for PowerShell (https://en.wikipedia.org/wiki/PowerShell) The original version is written for Geany by Enrico Tröger <enrico.troeger@uvena.de>: commit 8a6fbd978691fa324bd5c5ff171bcd508e3b466c Author: Enrico Tröger <enrico.troeger@uvena.de> Date: Sat Apr 25 16:17:03 2015 +0200 Add PowerShell tag parser @masatake did when merging: * edit this message, * replace -1, the value representing unknown kind with KIND_GHOST_INDEX, and * extend the original test case for testing signature. Known issue: * q/qualified extra doesn't work, and * the version of GPL doesn't written explicitly.
Close universal-ctags#2144 again. Quoted from universal-ctags#2144: ============================================================ @masatake commented 18 hours ago ------------------------------------------------------------ @eht16, I imported your NSIS parser from Geany to Universal-ctags. After merging, I noticed the version of GPL was not written explictly: * This source code is released for free distribution under the terms of the * GNU General Public License. Can I change this to * This source code is released for free distribution under the terms of the * GNU General Public License version 2 or (at your option) any later version. ? masatake commented 2 hours ago ------------------------------------------------------------ @eht16, hi, again. I have one more request. I would like to do the same (writing the version of GPL explitly) on your powershell parser. Is it o.k.? @eht16 commented 6 hours ago ------------------------------------------------------------ Yes, it's fine by me.
k-takata
reviewed
Oct 8, 2019
Comment on lines
+123
to
+125
| <ClCompile Include="..\main\powershell.c"> | ||
| <Filter>Source Files\Main</Filter> | ||
| </ClCompile> |
There was a problem hiding this comment.
powershell.c is in the parser folder, not main.
There was a problem hiding this comment.
Thank you.
Doesn't test running at appveyor use win32/ctags_vs2013.vcxproj.filters ?
Ideally, this kind of mistake should be detected by a test.
There was a problem hiding this comment.
*.vcxproj.filters is only used by the Visual Studio IDE for showing the (virtual) directory tree.
It is not used for building, so it cannot detect by CI.
masatake
added a commit
to masatake/ctags
that referenced
this pull request
Oct 8, 2019
…ilters Reported by @k-takata in universal-ctags#2228.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds one of the extra parsers we have in Geany except
those defined in c.c and except the markdown parser which is readLine()
based and not really superior to the regex-based parser ctags uses
(we should probably use the ctags parser in Geany instead).
The added a parser is for PowerShell (https://en.wikipedia.org/wiki/PowerShell)
The original version is written for Geany by Enrico Tröger enrico.troeger@uvena.de:
commit 8a6fbd978691fa324bd5c5ff171bcd508e3b466c
Author: Enrico Tröger enrico.troeger@uvena.de
Date: Sat Apr 25 16:17:03 2015 +0200
@masatake did when merging:
KIND_GHOST_INDEX, and
Known issue: