Defining interface for parsers (part 6 of 6) #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… block When printing COMMON blocks in tags format with --excmd=mixed, ctags should fills their pattern fields with their line number. lineNumberEntry field of tagEntryInfo structure represents the condition "When printing COMMON blocks in tags format with --excmd=mixed". I introduced changes handling the condtion twice. One is at field.c and another one is at writer-ctags.c. This change unifies them. The condtion is special for tags format. So writer-ctags.c should handle the condtion. field.c should not know the condtion. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
"Renderable" doesn't represent what the function predicates.
…efinition It was not good name as a type name. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
field.c and writer*.c had mutual dependencies. This change makes them one way, from writer*.c to field.c. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last PR for splitting the header files into two categories.
One is for parsers (public).
Another is for the main part (private).