build-sys: fix wrong usage of AC_CHECK_FUNCS used in checking mblen #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code defines `HAVE_MBLEN=1` when mblen is not found. It should be defined only when the function is found. AC_CHECK_FUNCS defines the macro automatically when it is defiend explicitly in the parameter list. So just specifying the name of function is enough. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
|
This implies the C code surrounded by #ifdef HAVE_MBLEN - #endif is not tested |
|
Does anyone have interest to write a test case for mblen? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code defines
HAVE_MBLEN=1when mblen is not found.It should be defined only when the function is found.
AC_CHECK_FUNCS defines the macro automatically when it is defiend
explicitly in the parameter list. So just specifying the name of
function is enough.
Signed-off-by: Masatake YAMATO yamato@redhat.com