Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-sys: Generate test-cases.mak even if git is not available #1513

Merged
merged 1 commit into from
Aug 1, 2017

Conversation

masatake
Copy link
Member

Close #1512

This is base on the pull request submitted by @derekschrock as #1512.

Quoted from the discussion at #1512:

No, you can download tarballs of a given commit via github from a
direct URL. FreeBSD's port infrastructure doesn't use git to download
github (or gitlab) repos. They're direct URLs so normal checksum
validation can still occur. Versioning can be a little odd sometimes
with non-tagged releases (rolling release) but once you wrap your head
around the idea it's pretty sane. For example:
https://codeload.github.com/universal-ctags/ctags/tar.gz/5567535e Can
be used to download universal-ctags/ctags commit 5567535. So git is
not required inside a basic FreeBSD build environment to pull in
upstream files for github sources. Just an http[s] client and checksum
validation.

This change may help people building u-ctags from a tar ball taken from
https://codeload.github.com/universal-ctags/ctags/tar.gz/.

Close universal-ctags#1512

This is base on the pull request submitted by @derekschrock as universal-ctags#1512.

Quoted from the discussion at universal-ctags#1512:

    No, you can download tarballs of a given commit via github from a
    direct URL. FreeBSD's port infrastructure doesn't use git to download
    github (or gitlab) repos. They're direct URLs so normal checksum
    validation can still occur. Versioning can be a little odd sometimes
    with non-tagged releases (rolling release) but once you wrap your head
    around the idea it's pretty sane. For example:
    https://codeload.github.com/universal-ctags/ctags/tar.gz/5567535e Can
    be used to download universal-ctags/ctags commit 5567535. So git is
    not required inside a basic FreeBSD build environment to pull in
    upstream files for github sources. Just an http[s] client and checksum
    validation.

This change may help people building u-ctags from a tar ball taken from
https://codeload.github.com/universal-ctags/ctags/tar.gz/.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.373% when pulling 80fd72a on masatake:improve-dist-test-cases into 5567535 on universal-ctags:master.

@masatake masatake merged commit b5d8ad1 into universal-ctags:master Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants