Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glyph, layer and other names need to exclude some characters. #80

Closed
typesupply opened this issue Jan 9, 2019 · 6 comments · Fixed by #135
Closed

Glyph, layer and other names need to exclude some characters. #80

typesupply opened this issue Jan 9, 2019 · 6 comments · Fixed by #135
Labels
approved Approved specification change. bug proposal Proposed specification change. ufo3 UFO 3 issues.

Comments

@typesupply
Copy link
Contributor

At the moment, the spec does not place any limitations on glyph, layer and (probably) other names can contain any character. This should be changed to exclude control characters.

@justvanrossum
Copy link
Contributor

I was thinking about this. The UFO spec contains features.fea, and that has more strict limits on glyph and group names than UFO itself. In other words, once you use features.fea, there are implied glyph and group name limitations. Am I missing something?

@typesupply
Copy link
Contributor Author

Correct, but the restrictions of the features.fea syntax don't percolate up to the UFO level. We don't require that the data in the UFO be 1:1 compatible with the data in features.fea.

@schriftgestalt
Copy link

What is the current recommendation of kerning class names? Is it OK to have hyphens?

@benkiel
Copy link
Contributor

benkiel commented May 12, 2019

The rules for UFO3 are here: http://unifiedfontobject.org/versions/ufo3/groups.plist/, other than the prefix for kerning groups, group names can contain any character (so it's ok to have hyphens) in the UFO (though, this should likely, as noted above, remove control characters). Do note that what the UFO allows and what the FDK allows may be different (UFO is looser, as noted above)

@schriftgestalt
Copy link

I got so far. Just wanted to ask if anyone knows of a limitation in the current toolchain.

@benkiel
Copy link
Contributor

benkiel commented May 14, 2019

@schriftgestalt Not from the UFO side, but you would want to check with the FDK and FontMake.

Looking here: http://adobe-type-tools.github.io/afdko/OpenTypeFeatureFileSpecification.html#2.g.ii it's not clear if the naming restrictions are from final or production names (production allows for hyphen). My guess is that it's final, but best to ask over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved specification change. bug proposal Proposed specification change. ufo3 UFO 3 issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants