Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import ICU4C enumerated properties data into ICU4X #883

Closed
iainireland opened this issue Jul 22, 2021 · 2 comments · Fixed by #1047
Closed

Import ICU4C enumerated properties data into ICU4X #883

iainireland opened this issue Jul 22, 2021 · 2 comments · Fixed by #1047
Assignees
@iainireland
Labels
C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality
Milestone
ICU4X 0.4

Comments

@iainireland
Copy link
Contributor

Using the upropdump tool (unicode-org/icu#1741), ICU4C can emit data for Unicode properties as a .toml file. Issue #882 tracks the import of binary properties. We should also import enumerated properties.
@iainireland iainireland added T-core Type: Required functionality C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) labels Jul 22, 2021
@iainireland iainireland self-assigned this Jul 22, 2021
@iainireland iainireland mentioned this issue Jul 22, 2021
Closed
@sffc
Copy link
Member

sffc commented Jul 22, 2021

Is this issue intended to cover binary enumerated properties (key/value as a UnicodeSet), actual enumerated properties (as a CodePointTrie), or both?

@iainireland iainireland mentioned this issue Jul 22, 2021
Merged
@iainireland
Copy link
Contributor Author

I haven't written a patch yet. It's intended to cover at least binary enumerated properties. If it makes sense to split that up from CodePointTrie-style enumerated properties, we can open a separate issue.

@sffc sffc added this to the ICU4X 0.4 milestone Jul 22, 2021
@iainireland iainireland mentioned this issue Aug 5, 2021
Closed
@aethanyc aethanyc mentioned this issue Aug 11, 2021
Closed
6 tasks
@iainireland iainireland mentioned this issue Sep 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iainireland iainireland

Labels
C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality
Projects
None yet
Milestone
ICU4X 0.4
Development

Successfully merging a pull request may close this issue.

Add binary enumerated properties data provider; update uprop toml files iainireland/icu4x
2 participants
@sffc @iainireland