-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final crate locations for unicodeset_parser
#3849
Comments
Decisions:
LGTM: @sffc @skius @robertbastian @eggrobin @Manishearth Notes:
|
On the topic of |
I would lean towards more consistency (and we still have time to rename casemap) but I do kinda like the shorter name |
I prefer |
Oh, yeah, I would consider it a mistake that we did noun-based names for the older crates. I think using "er"/"or" for the crate name is wrong because the crate contains functionality and doesn't declare exactly how that functionality is surfaced. The Go English making half of these end with "er" and half with "or". We don't have the suffix for the formatter crates like icu_decimal, icu_list, and icu_datetime. If we were starting from scratch I'd like to see:
I think casemap is different enough that we should stick with But I'm torn between Note that googling for "transliterate" gives much more useful results than "transliterator". So "transliterate" is better from an education point of view. How much are people going to really notice the difference between "collator" and "transliterate"? They serve different users with different use cases. So I think I lean toward |
|
unicodeset_parser
, transliterator_parser
unicodeset_parser
Where should the parsing crates for UnicodeSets (
icu_unicodeset_parser
) and transliterators (icu_transliterator_parser
) end up?Suggestion: The UnicodeSet parser could live as a utility crate under
icu_collections
, as it parses intoCodePointInversionListAndStringList
.The text was updated successfully, but these errors were encountered: