Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform final cleanup of YokeTraitHack and badly for Utils 1.0 #2825

Open
sffc opened this issue Nov 10, 2022 · 5 comments
Open

Perform final cleanup of YokeTraitHack and badly for Utils 1.0 #2825

sffc opened this issue Nov 10, 2022 · 5 comments
Labels
blocked A dependency must be resolved before this is actionable C-zerovec Component: Yoke, ZeroVec, DataBake help wanted Issue needs an assignee S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Milestone
Utilities 1.0

Comments

@sffc
Copy link
Member

sffc commented Nov 10, 2022

Follow-up to #1061 and #1133.
@sffc sffc added help wanted Issue needs an assignee C-data-infra Component: provider, datagen, fallback, adapters T-techdebt Type: ICU4X code health and tech debt blocked A dependency must be resolved before this is actionable S-small Size: One afternoon (small bug fix or enhancement) labels Nov 10, 2022
@sffc sffc added this to the Utilities 1.0 milestone Nov 10, 2022
@sffc sffc mentioned this issue Nov 10, 2022
Closed
@sffc
Copy link
Member Author

sffc commented Dec 15, 2022

@Manishearth does rust-lang/rust#101520 help clean up a bit of Yoke code?

@Manishearth
Copy link
Member

It ought to yes

@Manishearth
Copy link
Member

It's not on our 1.0 compiler though

@sffc sffc added C-zerovec Component: Yoke, ZeroVec, DataBake and removed C-data-infra Component: provider, datagen, fallback, adapters labels Dec 22, 2022
@sffc
Copy link
Member Author

sffc commented Aug 27, 2023

Now that MSRV is updated, can we apply rust-lang/rust#101520 to our code?

@Manishearth
Copy link
Member

Yes, if it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked A dependency must be resolved before this is actionable C-zerovec Component: Yoke, ZeroVec, DataBake help wanted Issue needs an assignee S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Projects
None yet
Milestone
Utilities 1.0
Development

No branches or pull requests
2 participants
@sffc @Manishearth