Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port UCPTrie to ICU4X #132

Closed
sffc opened this issue Jun 17, 2020 · 4 comments · Fixed by #711
Closed

Port UCPTrie to ICU4X #132

sffc opened this issue Jun 17, 2020 · 4 comments · Fixed by #711
Assignees
@echeran
Labels
C-unicode Component: Props, sets, tries S-large Size: A few weeks (larger feature, major refactoring) T-core Type: Required functionality
Milestone
ICU4X 0.4

Comments

@sffc
Copy link
Member

sffc commented Jun 17, 2020

UCPTrie is a data structure in ICU4C that maps from code points to integer values. This data structure is fundamental to various pieces of functionality, including enumerated Unicode properties. We should port this data structure to ICU4X.
@sffc sffc added T-core Type: Required functionality C-unicode Component: Props, sets, tries labels Jun 17, 2020
@sffc sffc added this to the 2020 Q3 milestone Jun 17, 2020
@sffc sffc mentioned this issue Jun 17, 2020
Closed
@kpozin
Copy link
Contributor

kpozin commented Jun 18, 2020

Could this be a wrapper on top of BytesTrie?

@sffc sffc mentioned this issue Jun 24, 2020
Closed
6 tasks
@sffc sffc modified the milestones: 2020 Q3, 2020 Q4, ICU4X 0.2 Oct 22, 2020
@sffc sffc mentioned this issue Mar 12, 2021
Closed
@sffc sffc assigned echeran and unassigned kpozin Mar 12, 2021
@sffc sffc mentioned this issue Mar 19, 2021
Closed
@sffc
Copy link
Member Author

sffc commented Mar 19, 2021

Implementation design doc: https://docs.google.com/document/d/1JkrL4pv477dIVnfilwlAEwqF9vstb_Uo_5XeUz2WXM8/edit#

@sffc sffc mentioned this issue Mar 29, 2021
Merged
@sffc sffc modified the milestones: ICU4X 0.2, 2021-Q2-m1 Apr 1, 2021
@echeran echeran mentioned this issue Apr 19, 2021
Closed
@echeran echeran added the S-large Size: A few weeks (larger feature, major refactoring) label Apr 19, 2021
@echeran echeran mentioned this issue Apr 23, 2021
Merged
3 tasks
@sffc sffc modified the milestones: 2021-Q2-m1, ICU4X 0.3 Apr 29, 2021
@echeran echeran mentioned this issue May 10, 2021
Merged
3 tasks
@echeran
Copy link
Contributor

echeran commented May 13, 2021

notes doc for meeting with @markusicu on details & explanations of CodePointTrie implementation : https://docs.google.com/document/d/1yS9emU-G2EhXF9XgSf8suY8RWduYKBZNmDIaFY-qD_I/edit#

@markusicu
Copy link
Member

FYI UCPTrie is a C API name. If we had a proper C++ API it would follow the naming conventions of Java where it's called CodePointTrie. ICU4X/Rust should probably follow Java naming more closely here.

@echeran echeran modified the milestones: ICU4X 0.3, ICU4X 0.4 Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@echeran echeran

Labels
C-unicode Component: Props, sets, tries S-large Size: A few weeks (larger feature, major refactoring) T-core Type: Required functionality
Projects
None yet
Milestone
ICU4X 0.4
Development

Successfully merging a pull request may close this issue.

Port ICU4C code point trie echeran/icu4x
4 participants
@kpozin @echeran @sffc @markusicu