Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor property definitions to a separate crate #1160

Closed
echeran opened this issue Oct 7, 2021 · 0 comments · Fixed by #1153
Closed

Refactor property definitions to a separate crate #1160

echeran opened this issue Oct 7, 2021 · 0 comments · Fixed by #1153
Assignees
@echeran
Labels
C-unicode Component: Props, sets, tries S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Milestone
ICU4X 0.4

Comments

@echeran
Copy link
Contributor

echeran commented Oct 7, 2021

We have our enums / newtypes that represent Unicode properties in the icu_uniset crate currently, but they are an independent concept from specific data structures, and therefore they deserve their own separate place in the codebase.

This will help clear up dependencies when the CodePointTrie APIs for Unicode properties in icu_codepointtrie are added, since they will depend on enumerated property enums / newtypes, while already some of the APIs in icu_uniset for returning UnicodeSets for Unicode properties depend on enumerated property enums / newtypes (ex: returning the UnicodeSet for "gc=Math_Symbol")
@echeran echeran added C-unicode Component: Props, sets, tries T-techdebt Type: ICU4X code health and tech debt S-small Size: One afternoon (small bug fix or enhancement) labels Oct 7, 2021
@echeran echeran added this to the ICU4X 0.4 milestone Oct 7, 2021
@echeran echeran self-assigned this Oct 7, 2021
@echeran echeran linked a pull request Oct 7, 2021 that will close this issue
Refactor properties to separate crate #1153
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@echeran echeran

Labels
C-unicode Component: Props, sets, tries S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Projects
None yet
Milestone
ICU4X 0.4
Development

Successfully merging a pull request may close this issue.

Refactor properties to separate crate echeran/icu4x
1 participant
@echeran