ICU-23059 Update spec tests #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catamorphism
force-pushed
the
february-2025-spec-tests
branch
from
3879983 to
20e8d2a
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
This updates the MF2 spec tests to unicode-org/message-format-wg@943479b with the following exceptions: - functions/currency.json and functions/math.json are omitted because these are not yet implemented - bidi.json will be handled in a future PR - u-options.json will be handled in a future PR Changes include: * `:integer` now returns a value encapsulating the rounded numeric value of the argument, rather than the value itself. * Fallbacks are handled according to the current spec. * Fallback values are not passed into functions. * Characters inside literal fallbacks are properly escaped. * The test runner skips null values properly. * The test runner handles boolean `expErrors` in defaultTestProperties. * `:string` normalizes its input and normalizeNFC() has been refactored so it can be called there.
catamorphism
force-pushed
the
february-2025-spec-tests
branch
from
6112d3e to
c546c6b
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
catamorphism
changed the title
srl295
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the MF2 spec tests to unicode-org/message-format-wg@943479b with the following exceptions:
functions/currency.json and functions/math.json are omitted because these are not yet implemented
bidi.json will be handled in a future PR
u-options.json will be handled in a future PR
Changes include:
*
:integernow returns a value encapsulating the rounded numeric value of the argument, rather thanthe value itself.
* Fallbacks are handled according to the current spec.
* Fallback values are not passed into functions.
* Characters inside literal fallbacks are properly escaped.
* The test runner skips null values properly.
* The test runner handles boolean
expErrorsin defaultTestProperties.*
:stringnormalizes its input and normalizeNFC() has been refactored so it can be called there.Checklist