Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port ignoreUnusedTypeExports option of no-unused-modules #86

Closed
silverwind opened this issue May 28, 2024 · 5 comments · Fixed by #116
Closed

Port ignoreUnusedTypeExports option of no-unused-modules #86

silverwind opened this issue May 28, 2024 · 5 comments · Fixed by #116

Comments

@silverwind
Copy link

I'm willing to port import-js#3011 into this module, it's a useful option to have.
@SukkaW
Copy link
Collaborator

SukkaW commented Jun 29, 2024

@silverwind Sure! Please do. It is indeed a great option.

@silverwind
Copy link
Author

Waiting a bit more for that PR to review/merge.

@SukkaW
Copy link
Collaborator

SukkaW commented Jul 1, 2024

@silverwind You can backport here first since I can review PR quicker and more frequently. The test infra here is better as well.

@SukkaW SukkaW mentioned this issue Jul 8, 2024
Open
@silverwind
Copy link
Author

silverwind commented Jul 18, 2024 •
edited
Loading

I have decided to disable no-unused-modules in my configs, so I'm sorry but I'm no longer interested in porting this option.

@silverwind silverwind closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2024
@silverwind silverwind mentioned this issue Jul 18, 2024
Merged
@silverwind
Copy link
Author

silverwind commented Jul 18, 2024 •
edited
Loading

Actually I gave it a second thought and would enable that rule again if ignoreUnusedTypeExports is supported, so here is the port: #116.

@silverwind silverwind reopened this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add ignoreUnusedTypeExports option to no-unused-modules silverwind/eslint-plugin-import
2 participants
@silverwind @SukkaW