Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] esbuild 升级到 0.17.0 #10305

Closed
fz6m opened this issue Jan 16, 2023 · 2 comments
Closed

[Feature Request] esbuild 升级到 0.17.0 #10305

fz6m opened this issue Jan 16, 2023 · 2 comments
Labels
PR Welcome

Comments

@fz6m
Copy link
Contributor

fz6m commented Jan 16, 2023 •
edited
Loading

Background

esbuild 0.17.0 语法有 Breaking change ，需要改动所有使用 watch 的地方。

参考：https://github.com/evanw/esbuild/releases/tag/v0.17.0

做法：

  1. 升级所有 esbuild 到 0.17.0

  2. 改动所有 esbuild watch 的地方到新语法
@BBBigCat BBBigCat mentioned this issue Jan 17, 2023
Closed
@Chastrlove Chastrlove mentioned this issue Jan 17, 2023
Closed
@fz6m fz6m linked a pull request Jan 17, 2023 that will close this issue
feat: bump esbuild -> 0.17.1 , use the new context api #10310
Closed
@fz6m
Copy link
Contributor Author

fz6m commented May 26, 2023

目前 vite 已 breaking 到 esbuild 0.17.x ，vitejs/vite#11908

这个升级应该加上日程， @Chastrlove 如果有空的话，这个 PR 可以重开一下，没时间的话后面我来搞也行。

@Chastrlove Chastrlove mentioned this issue May 27, 2023
Merged
@Chastrlove
Copy link
Contributor

目前 vite 已 breaking 到 esbuild 0.17.x ，vitejs/vite#11908

这个升级应该加上日程， @Chastrlove 如果有空的话，这个 PR 可以重开一下，没时间的话后面我来搞也行。

新开了一个PR，xn review 下

@fz6m fz6m closed this as completed May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR Welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: bump esbuild -> 0.17.1 , use the new context api
2 participants
@Chastrlove @fz6m