feat: import path for global styles #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 292a896 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sorrycc
approved these changes
Nov 12, 2024
|
提交前记得执行下 pnpm ci 。 |
|
好的，下次注意 |
|
@iamwangqing changeset 没提交 |
xiaohuoni
reviewed
Nov 13, 2024
sorrycc
requested changes
Nov 13, 2024
src/sync.ts
Outdated
| ${globalStyleImportPath} | ||
| ${tailwindcssPath ? `import '${tailwindcssPath}'` : ''} | ||
| ${overridesStyleImportPath} |
There was a problem hiding this comment.
overrides 不要，这个如果要加得讨论下，感觉需求不强烈。
There was a problem hiding this comment.
overrides 在这里不能达到预期的效果。
然后，在 umi 里面，global.css 的歧义很大，由于页面都是 lazy load 的，所以在 global 写的组件（多为 antd）样式，并不会生效。所以使用到 antd 的时候，overrides 几乎是必须的。
There was a problem hiding this comment.
那暂时先不加吗，等讨论确定之后在加？
feat:add overrides file to write
…into feature_global_style1
sorrycc
reviewed
Nov 13, 2024
sorrycc
approved these changes
Nov 13, 2024
sorrycc
changed the title
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add write src/global.{less,css} to client entry. The issue address is no.26