Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.1.1] Invalid composition when using nested document types #16872

Open
mattbrailsford opened this issue Aug 6, 2024 · 4 comments
Open

[14.1.1] Invalid composition when using nested document types #16872

mattbrailsford opened this issue Aug 6, 2024 · 4 comments
Assignees
Labels
affected/v14 affected/v15 area/frontend state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks type/bug

Comments

@mattbrailsford
Copy link
Contributor

mattbrailsford commented Aug 6, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.1.1

Bug summary

When migrating a site from v13 to v14 where nested document types are in use, when attempting to save changes to said document type I receive the error "Invalid composition - The specified document type composition is invalid".

I believe this is due to that fact that nestable document types have not yet been implemented in v14. Whilst that is being implemented, I think we should at least update the validation logic to allow nested document types to ensure changes can be saved.

Specifics

No response

Steps to reproduce

  • Create a v13 site
  • Create a document type
  • Create a nested document type under this document type
  • Migrate the site to v14
  • Make changes to the parent document type
  • Receive error

Expected result / actual result

At the very least it should be possible to save changes on such a setup, but it would also be nice to be able to create nested document types again (or if not, some way of migrating away from nested document types)


This item has been added to our backlog AB#44592

@elit0451 elit0451 added the state/needs-investigation This requires input from HQ or community to proceed label Aug 14, 2024
@elit0451
Copy link
Contributor

Hey Matt,

Unfortunately, I wasn't able to reproduce the error on an upgrade from 13.4.1 to 14.1.1. Can you check my setup and let me know if I'm missing a step? 🙂

NestedDocTypes.mov

@elit0451
Copy link
Contributor

Oops,

I noticed that I changed the nested doc type, as opposed to the parent one as you suggested, so here is the requested flow (still successful on my end):

SecondTry.mov

@mattbrailsford
Copy link
Contributor Author

mattbrailsford commented Aug 14, 2024

I think it could be an issue where nested and inherited element types are used at the same time. You can try the UC demo store if you want to see the issue in an install https://github.com/umbraco/Umbraco.Commerce.DemoStore/tree/feature/v14

In here, if you save the Product Page document type, it will throw an exception. This is both nested, and inherits an element type.

@arknu
Copy link
Contributor

arknu commented Jan 16, 2025

@leekelleher Any ETA on fixing this?

I find it quite concerning that there are still such serious regressions in v15... What other features are missing to be discovered only once we upgrade a site?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected/v14 affected/v15 area/frontend state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks type/bug
Projects
None yet
Development

No branches or pull requests

5 participants