Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong URL reported with SvelteKit client-side navigation #2637

Closed
notramo opened this issue Apr 2, 2024 · 10 comments
Closed

Wrong URL reported with SvelteKit client-side navigation #2637

notramo opened this issue Apr 2, 2024 · 10 comments
Labels
bug Something isn't working fixed in dev Fixed in the dev branch

Comments

@notramo
Copy link

notramo commented Apr 2, 2024

Describe the Bug

The full URL is reported when navigating using SvelteKit client-side navigation (clicking a link on the hydrated page).
The correct URL is reported when reloading page, even if the tracker script is inserted during hydration (SSR page does not include it).
E.g. the analytics page shows https://example.com/contact/ instead of /contact/ for pages that are navigated client-side.

This causes incorrect statistics, as one page can have 2 URLs (relative with direct navigation and absolute with client-side navigation) which have separate view counting.

Database

Umami Cloud

Relevant log output

No response

Which Umami version are you using? (if relevant)

Umami Cloud

Which browser are you using? (if relevant)

Firefox

How are you deploying your application? (if relevant)

Umami Cloud

@eumarcelo
Copy link

Same issue here, any luck solving it?

@madmax
Copy link

madmax commented Apr 7, 2024

Me too :(

@CediGasser
Copy link
Contributor

Same issue here using self hosted umami v2.11.0. Although, is showing only the path really the intended behavior? With two domains I could not differentiate between them anymore.

@notramo
Copy link
Author

notramo commented Apr 15, 2024

The two domains should have different site IDs probably.

@mikecao
Copy link
Collaborator

mikecao commented Apr 16, 2024

Should be fixed by this PR, #2679. We will release a hotfix.

@mikecao mikecao added bug Something isn't working fixed in dev Fixed in the dev branch labels Apr 17, 2024
@mikecao
Copy link
Collaborator

mikecao commented Apr 17, 2024

Fixed in v2.11.2.

@mikecao mikecao closed this as completed Apr 17, 2024
@acerasoni
Copy link

@mikecao, upgrading to >2.11.2 fixed the issue, but I have a significant amount of data captured before the fix was released which is a little troublesome when generating reports. For example, when generating a report for the last 12 months I still see split metrics for the https://.../blog and /blog variants from before I upgraded. Is there a way to merge these datasets retroactively?

@mikecao
Copy link
Collaborator

mikecao commented Dec 18, 2024

@acerasoni You would have to run a script to update your data.

@madmax
Copy link

madmax commented Dec 19, 2024

@mikecao What script should be run?

@mikecao
Copy link
Collaborator

mikecao commented Dec 19, 2024

@madmax You would have to come up with it. You can probably do it in pure SQL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in dev Fixed in the dev branch
Projects
None yet
Development

No branches or pull requests

6 participants