Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New line in VERSION on git pull #232

Closed
creoludifico opened this issue Jan 19, 2017 · 7 comments
Closed

New line in VERSION on git pull #232

creoludifico opened this issue Jan 19, 2017 · 7 comments
Assignees
@creoludifico
Labels
bug Critical Ready for testing
Milestone
V2.4

Comments

@creoludifico
Copy link
Collaborator

When pulling via git the following issue occur.
The VERSION file gets a newline which makes it impossible to login because of HTTP 500 error.
@ukdtom ukdtom added this to the V2.4 milestone Jan 19, 2017
@ukdtom
Copy link
Owner

ukdtom commented Jan 20, 2017

I simply can't replicate on Linux here....
Could you attach a faulty version file please

@ukdtom ukdtom assigned creoludifico and unassigned ukdtom Jan 20, 2017
@creoludifico
Copy link
Collaborator Author

VERSION.txt

@creoludifico creoludifico assigned ukdtom and unassigned creoludifico Jan 21, 2017
@ukdtom
Copy link
Owner

ukdtom commented Jan 21, 2017

Fixed ?

aea705b

@ukdtom ukdtom assigned creoludifico and unassigned ukdtom Jan 21, 2017
@creoludifico
Copy link
Collaborator Author

I still gets the error with the "\n".
I guess it's both the newline and the "\n" newline that is causing the error.
Try keeping the "\n" replace.
VERSION.txt

@ukdtom
Copy link
Owner

ukdtom commented Jan 21, 2017

Darn, cuz doesn't show on Linux here 👎

Guess I have to migrate to the dark side for a short time then for testing, but have no fear...I will return ;-)

@ukdtom ukdtom assigned ukdtom and unassigned creoludifico Jan 21, 2017
@ukdtom ukdtom mentioned this issue Jan 22, 2017
Closed
@ukdtom
Copy link
Owner

ukdtom commented Jan 22, 2017

Fixed with d5e55c2

@ukdtom ukdtom assigned creoludifico and unassigned ukdtom Jan 22, 2017
@creoludifico
Copy link
Collaborator Author

Beautiful.
Confirmed working

@ukdtom ukdtom mentioned this issue Jan 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@creoludifico creoludifico

Labels
bug Critical Ready for testing
Projects
None yet
Milestone
V2.4
Development

No branches or pull requests
2 participants
@ukdtom @creoludifico