Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prop-types as direct dependency, not peer dependency #70

Closed
Kukkimonsuta opened this issue Oct 8, 2017 · 1 comment
Closed

Use prop-types as direct dependency, not peer dependency #70

Kukkimonsuta opened this issue Oct 8, 2017 · 1 comment

Comments

@Kukkimonsuta
Copy link
Contributor

Documentation:
https://github.com/facebook/prop-types#how-to-depend-on-this-package

Discussion arou this topic:
facebook/prop-types#44

@elboman
Copy link
Member

elboman commented Oct 17, 2017

Thanks for pointing it out.

So basically it's a matter or reducing pain for the user with peerDependencies.

Will do 👍

@elboman elboman closed this as completed in 5c6b2dd Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants